Letractively / lightblog

Automatically exported from code.google.com/p/lightblog
Other
0 stars 0 forks source link

Delete config-example.php, SQL files, installer, etc. in the installer itself. #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The code which deletes config-example.php, the SQL files, the installer itself, 
updater, and so on, should be deleted within their respective files.

There isn't much reason to have LightBlog, on every page load, to check if the 
install.php file is there, as it's kind of wasted resources (not that it slows 
it down too much).

Also, there should be a switch so when in development mode that the installer 
(and it's files) do not get deleted when testing it out.

(perhaps a constant INDEVMODE in install.php/update.php that, when true, will 
not execute the code to remove these items [the switch is always set to true, 
except when we package it up for non-development use])

Original issue reported on code.google.com by ian.aldr...@gmail.com on 21 Jun 2012 at 6:12

GoogleCodeExporter commented 8 years ago
You've partially caught on to the reason why I wrote the file remover that way: 
I didn't want to remove the files in a dev environment (since I just have my 
SVN working copy symbolically linked to my dev server root.)

I like your constant idea better: do that.

Original comment by soren121@outlook.com on 21 Jun 2012 at 6:43

GoogleCodeExporter commented 8 years ago
Alrighty, I will do that ;-)

Original comment by ian.aldr...@gmail.com on 21 Jun 2012 at 6:43

GoogleCodeExporter commented 8 years ago
This has been fixed in SVN r541.

Original comment by soren121@outlook.com on 22 Jun 2012 at 2:48