Letractively / lightblog

Automatically exported from code.google.com/p/lightblog
Other
0 stars 0 forks source link

Auto-fill commenter info for logged in users and prevent guests from using registered names (and preservation of data) #51

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This is fairly straightforward, I do believe...

First off, if the user is logged in they should not see the input fields for 
name, email address and website. They should instead see "You are posting as 
{user name}." instead. When the comment is submitted, their data will be set 
then. Currently there is no place to set their website in their profile, 
perhaps this should be added? If we don't want to do that now we can just show 
the input for a website.

Second, when posting a comment as a guest, the name and email address being 
used should be checked. Guests should not be allowed to use a name or an email 
address that is already in use by an existing user. This would help prevent any 
impersonation attempts.

Finally, if the guest so chooses, their name, email address and website 
information should be preserved and auto-filled by saving it to a cookie.

Original issue reported on code.google.com by ian.aldr...@gmail.com on 24 Jun 2012 at 7:13

GoogleCodeExporter commented 9 years ago
I agree with the logged-in view for comments, as well as the website field for 
their profile. I'll add the website field.

I don't think that you should check for impersonation attempts. I know from 
experience that less tech-savvy users won't login to comment: they'll just fill 
out the form. I don't know why. This behavior persisted even when I added a 
notice to the comment form that said "If you have an account here, please login 
first", with the second phrase linked to the login page.

tl;dr: Yay to everything except impersonation checks.

Original comment by soren121@outlook.com on 24 Jun 2012 at 7:19

GoogleCodeExporter commented 9 years ago

Original comment by soren121@outlook.com on 24 Jun 2012 at 7:19

GoogleCodeExporter commented 9 years ago
Are you sure about the impersonation thing?

I mean, they don't have to create an account, and it's unlikely on a blog that 
someone would create an account just 'cause. So if that name doesn't belong to 
them and it isn't their account, they would just have to choose a different 
name.

I suppose we could add a small (registered) after their name if the comment 
came from a registered account instead.

Original comment by ian.aldr...@gmail.com on 24 Jun 2012 at 7:32

GoogleCodeExporter commented 9 years ago
I know that WordPress allows theme devs to know if a comment came from a 
registered user. We could add that.

Original comment by soren121@outlook.com on 24 Jun 2012 at 9:18

GoogleCodeExporter commented 9 years ago
This issue was fixed by r561.

Original comment by ian.aldr...@gmail.com on 24 Jun 2012 at 10:14