Stock images show in the same fancybox as in-preview

[GoogleCodeExporter]

http://www.zetaprints.com/magento/index.php/featured/interactive-personalization
.html

== Problems ==

Open in-preview editor.
Click on a field.
Click on a stock image from the library.
It replaces the preview with the stock image, but keeps UPDATE PREVIEW at the 
top. Now I am confused ... where the heck am I? Am I looking at the preview or 
a stock image?

There is no way to get back to in-preview screen, so I have to close it and 
then open again.

If I step through multiple images and click update preview it won't use the img 
I'm looking at, but the one with the radio button. Totally confusing.

== Solution ==

1. replace "Update preview" button on the stock image screen with "Use image", 
clicking on which selects the image as if the radio button was clicked
2. currently selected image should have grey "Selected image" instead of "Use 
image"
3. close the image preview window when an image is selected or X clicked
4. go back to the in-preview window when stock image window is closed

Original issue reported on code.google.com by ad...@zetaprints.com on 29 Jul 2011 at 1:20

• Blocked on: #628, #631

[GoogleCodeExporter]

Actually it's a big bug :-( But that's how fancybox works, it allows only one 
fancy per browser window.

I have some ideas why it worked before.

Original comment by Anatoly....@gmail.com on 29 Jul 2011 at 11:23

[GoogleCodeExporter]

Erm... did it work before at all? :-)

Original comment by Anatoly....@gmail.com on 29 Jul 2011 at 7:54

[GoogleCodeExporter]

I don't think anyone noticed.
We are cool with 1 fancybox only. It's just how it fits into the rest of the 
workflow is the problem.

Original comment by ad...@zetaprints.com on 29 Jul 2011 at 10:47

[GoogleCodeExporter]

Need mock-ups for final design and icons.

Original comment by Anatoly....@gmail.com on 7 Aug 2011 at 11:21

[GoogleCodeExporter]

Attached the check icon as a separate image (check_ico_stock.png)
Let me know if you want it as part of some sprite.

Original comment by agur...@gmail.com on 8 Aug 2011 at 10:08

Attachments:

• D3-1.png
• D3-2.png
• check_ico_stock.png

[GoogleCodeExporter]

Please, add icon to 
https://magento-w2p.googlecode.com/svn/trunk/js/fancybox/images/zp-update-previe
w-button-sprite.png sprite.

Original comment by Anatoly....@gmail.com on 8 Aug 2011 at 11:58

[GoogleCodeExporter]

Original comment by agur...@gmail.com on 8 Aug 2011 at 12:11

Attachments:

• zp-update-preview-button-sprite.png

[GoogleCodeExporter]

Diffs:

 * http://code.google.com/p/magento-w2p/source/detail?r=1759
 * http://code.google.com/p/magento-w2p/source/detail?r=1760
 * http://code.google.com/p/magento-w2p/source/detail?r=1765
 * http://code.google.com/p/magento-w2p/source/detail?r=1767

Atanas, please, update BG locale. See diff at 
http://code.google.com/p/magento-w2p/source/diff?spec=svn1767&r=1767&format=side
&path=/trunk/app/locale/en_US/ZetaPrints_WebToPrint.csv

Original comment by Anatoly....@gmail.com on 9 Aug 2011 at 5:49

• Changed state: Finished

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 9 Aug 2011 at 5:50

[GoogleCodeExporter]

I'm not sure what the BG translation should be. We should ask Petar, I guess.

Original comment by agur...@gmail.com on 9 Aug 2011 at 6:10

[GoogleCodeExporter]

Oh, sorry, I mean MK one :-)

Original comment by Anatoly....@gmail.com on 9 Aug 2011 at 6:26

[GoogleCodeExporter]

Anatoly, I'm lost when it comes down to this G-code SVN, honestly :( takes me 
forever to find what I need
Attach the file in your comment and I'll edit and attach it back for you to 
commit.

Original comment by agur...@gmail.com on 9 Aug 2011 at 6:32

[GoogleCodeExporter]

http://magento-w2p.googlecode.com/svn/trunk/app/locale/mk_MK/ZetaPrints_WebToPri
nt.csv

Original comment by Anatoly....@gmail.com on 9 Aug 2011 at 7:52

[GoogleCodeExporter]

Original comment by agur...@gmail.com on 9 Aug 2011 at 8:42

Attachments:

• ZetaPrints_WebToPrint.csv

[GoogleCodeExporter]

Please, test it with 1.9.1.0alpha16 release.

Original comment by Anatoly....@gmail.com on 10 Aug 2011 at 9:24

• Changed state: ToTest

[GoogleCodeExporter]

Tested on web_to_print_store_incl_theme 1.9.1.0alpha16 (alpha)
/magedev/ M. ver. 1.5.0.1
http://d1.zetaprints.com/magedev/index.php/magentot-01/1pg-template.html

/mageimage/ M. ver. 1.6.0.0-rc2
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html

Top left image has stock images assigned. The FancyBox doesn't show, whole 
thing gets blocked when I click on a stock image and I need to refresh the page 
to get out of there.

Original comment by agur...@gmail.com on 11 Aug 2011 at 9:25

• Changed state: MoreWork

[GoogleCodeExporter]

Please, choose another template for testing. The bug is not relative to the 
fancybox.

Original comment by Anatoly....@gmail.com on 11 Aug 2011 at 9:47

• Changed state: ToTest

[GoogleCodeExporter]

Different template:
http://d1.zetaprints.com/mageimage/index.php/magentot-01/2pg-template.html
http://d1.zetaprints.com/magedev/index.php/magentot-01/2pg-template.html

same results

Original comment by agur...@gmail.com on 11 Aug 2011 at 10:26

• Changed state: MoreWork

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 11 Aug 2011 at 10:43

[GoogleCodeExporter]

Please, re-test it with 1.9.1.0alpha17 release.

Original comment by Anatoly....@gmail.com on 15 Aug 2011 at 1:47

• Changed state: ToTest

[GoogleCodeExporter]

Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha18 (alpha)

Image selection doesn't work in IE7. Works ok in all the other browsers.

Original comment by agur...@gmail.com on 16 Aug 2011 at 1:49

• Changed state: MoreWork

[GoogleCodeExporter]

The error is not relative to image selection.

Original comment by Anatoly....@gmail.com on 16 Aug 2011 at 3:20

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 7:22

• Changed state: Finished

[GoogleCodeExporter]

Please, re-test it with 1.9.1.0alpha19 release.

Original comment by Anatoly....@gmail.com on 17 Aug 2011 at 8:12

• Changed state: ToTest

[GoogleCodeExporter]

Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

Original comment by agur...@gmail.com on 17 Aug 2011 at 4:55

• Changed state: TestOK

[GoogleCodeExporter]

Tested on /mageimage/
web_to_print_store_incl_theme   1.9.1.0alpha19 (alpha)

Original comment by agur...@gmail.com on 17 Aug 2011 at 7:06

[GoogleCodeExporter]

oops

went to http://d1.zetaprints.com/magedev/index.php/magentot-01/2pg-template.html
clicked on the shape, stepped left - right, then clicked USE IMAGE, then 
clicked X to close it - nothing

this is the error I got

Error: shapes is undefined
Source File: 
http://d1.zetaprints.com/magedev/skin/frontend/base/default/js/zp-in-preview-edi
t.js
Line: 370

using FF 3.6
bah

Original comment by ad...@zetaprints.com on 17 Aug 2011 at 9:20

• Changed state: MoreWork

[GoogleCodeExporter]

Why did you try it on /magedev/ ?
that instance still has 
web_to_print_store_incl_theme 1.9.1.0alpha16 (alpha)
as we as being M. 1.5.0.1
latest release is web_to_print_store_incl_theme 1.9.1.0alpha19 (alpha) and I'm 
testing it on /mageimage/ M. 1.6

The weird thing is that I just tried your link and it worked for me. Only tried 
it in FF though, but I was able to browse through the stocks, select my image 
and update the preview.

Original comment by agur...@gmail.com on 18 Aug 2011 at 7:34

• Changed state: TestOK

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 5 Sep 2011 at 4:56

• Added labels: Period-2011-08

[GoogleCodeExporter]

Original comment by ad...@zetaprints.com on 6 Sep 2011 at 11:28

• Added labels: Unit-2
• Removed labels: Unit-0.5

[GoogleCodeExporter]

Original comment by ad...@zetaprints.com on 16 Sep 2011 at 12:06

• Changed state: Done