Letractively / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Bad HTML #644

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Been chastised by Steve for producing baaaaddd HTML with tags not being closed, 
etc, etc.

1. Run an HTML validator on our HTML
2. List all the issues
3. Fix the issues

We will need to do detailed testing after this in all browsers.

Original issue reported on code.google.com by ad...@zetaprints.com on 7 Sep 2011 at 1:52

GoogleCodeExporter commented 9 years ago
I tidied up HTML code. Just check that product page works as usual.

Please, use 1.9.2.0alpha4 release for testing.

Diffs: http://code.google.com/p/magento-w2p/source/detail?r=1804

Original comment by Anatoly....@gmail.com on 30 Sep 2011 at 10:19

GoogleCodeExporter commented 9 years ago
Diffs:

* http://code.google.com/p/magento-w2p/source/detail?r=1805
* http://code.google.com/p/magento-w2p/source/detail?r=1806

Original comment by Anatoly....@gmail.com on 1 Oct 2011 at 12:57

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 1 Oct 2011 at 3:40

GoogleCodeExporter commented 9 years ago
I guess this can be tested after it is installed on some public instance since 
the online validators need to be able to reach the site.
I can test it on a customer site but customers don't install alphas. Probably 
test it in the demo store after we upgrade it.

Original comment by agur...@gmail.com on 5 Oct 2011 at 1:00

GoogleCodeExporter commented 9 years ago
Use html code of the page.

Original comment by Anatoly....@gmail.com on 5 Oct 2011 at 4:47

GoogleCodeExporter commented 9 years ago
Thx for the tip, Anatoly!

Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha6 (alpha)

Validated product page HTML for
1.9.2.0alpha2 - 35 Errors found while checking this document as XHTML 1.0 
Strict!
1.9.2.0alpha6 - This document was successfully checked as XHTML 1.0 Strict!

Original comment by agur...@gmail.com on 5 Oct 2011 at 5:45

GoogleCodeExporter commented 9 years ago
Clean install of 1.9.2.0alpha6 on 1.6.0.0 none of the image handling stuff
works. it is impossible to open the bar.

Product: A4 Brochure 01
URL: http://admin.mediagenerator.co/
Key: 38005124-df1e-4331-b344-b0f51f23b820
Default Theme: zptheme

Polaroid Photo
Front Background

will not open.

Default product display ( first opened, no previews attempted, no fields
filled in ) show 7 errors, ( cut/paste from w3c )

<img rel=*"*page-1" src="http://admin.mediagenerato�

pe="hidden" name="parameter" value="Polaroid
photo"/><table><tr/*>*</table></div>
(repeted 6 times for different fields)

Original comment by steve.ho...@gmail.com on 7 Oct 2011 at 2:07

GoogleCodeExporter commented 9 years ago
Got a link to the product, Steve?

Original comment by ad...@zetaprints.com on 7 Oct 2011 at 4:49

GoogleCodeExporter commented 9 years ago
http://www.adoremat.co.uk/index.php/the-magnetic-board-company-magnetic-boards/t
est.html

As I've mentioned before, I'm behind this screwed up transparent proxy
thanks to Voda. Today, ZP code is not working at all for me - code untouched
from yesterday AFAICT. Admin login admin/admin123. Feel free to do whatever
you wish.

It's a real bummer not getting repeatable results!

I forgot to send this - a couple of hours ago. It is now working. All of it.
So I've now had all, some or none of the code working without changing any
code.

I think I'm going to have to move away from Vodafone as an ISP.

Original comment by steve.ho...@gmail.com on 8 Oct 2011 at 2:50

GoogleCodeExporter commented 9 years ago
@9 - what do you want us to do?
The page is plain broken.

Original comment by ad...@zetaprints.com on 10 Oct 2011 at 12:31

GoogleCodeExporter commented 9 years ago
The page works for me.

Original comment by Anatoly....@gmail.com on 10 Oct 2011 at 4:36

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 12 Oct 2011 at 12:02