search

Letractively / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

"Page size" independent of download permission #649

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Current "Page size" feature is set to show the table only if the template has 
download set to "Allow" in template details on w2p portal. This is the code, 
probably:
http://code.google.com/p/magento-w2p/source/detail?r=1667
as part of:
http://code.google.com/p/magento-w2p/issues/detail?id=513

We need to make this table visible for the activated output file formats 
regardless of weather they are allowed for downloading.

I guess for the time being, admins will only be able to activate the page size 
table on a global level - for all templates.

Original issue reported on code.google.com by agur...@gmail.com on 8 Sep 2011 at 9:56

GoogleCodeExporter commented 9 years ago 
No, actually it's not. I don't see any check for download option.

Original comment by Anatoly....@gmail.com on 8 Sep 2011 at 7:30

GoogleCodeExporter commented 9 years ago 
Atanas, can you check if this is valid?
Looks like I missed the point here.

Original comment by ad...@zetaprints.com on 3 Oct 2011 at 10:17

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha5 (alpha) 

It is dependant. This product doesn't show its page size table:
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
because the download permission is set to "deny". If you change the download 
permission for the template:
http://cname.zetaprints.com/?page=template;TemplateID=6443E134-4CD1-4D33-841D-16
36502671A4
to "allow", the product page will show the page size table. Obviously related.

Original comment by agur...@gmail.com on 3 Oct 2011 at 5:10

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 4 Oct 2011 at 2:30

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 1 Nov 2011 at 6:46

GoogleCodeExporter commented 9 years ago 
Can this please be resolved in the next alpha?

Original comment by ad...@zetaprints.com on 1 Nov 2011 at 6:48

GoogleCodeExporter commented 9 years ago 
Diff: http://code.google.com/p/magento-w2p/source/detail?r=18

Original comment by Anatoly....@gmail.com on 8 Nov 2011 at 7:09

GoogleCodeExporter commented 9 years ago 
Please, test with 1.9.2.0alpha15 (already installed on /mageimage/)

Original comment by Anatoly....@gmail.com on 8 Nov 2011 at 7:21

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha15 (alpha)

It is still dependent.
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
Now if I have download permission set to "deny", I only see the table icon 
(page_size.png). I still need to set the download permission to "allow" to get 
the table populated with actual values.

Original comment by agur...@gmail.com on 9 Nov 2011 at 3:36

Attachments:

GoogleCodeExporter commented 9 years ago 
Diff: http://code.google.com/p/magento-w2p/source/detail?r=1831

Original comment by Anatoly....@gmail.com on 9 Nov 2011 at 4:42

GoogleCodeExporter commented 9 years ago 
Please, test with 1.9.2.0beta15 release

Original comment by Anatoly....@gmail.com on 9 Nov 2011 at 7:25

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0beta15 (beta)

Only the PDF size is independent of the download permission. The rest of the 
dimensions still are.

Explanation:
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
- This product has all output files set to be generated 
(page_size_options.png). While the download permission is set to "deny", only 
the PDF value is shown (page_size_options_02.png) 
If you change the download permission to "allow", all options show up 
(page_size_options_03.png).

Original comment by agur...@gmail.com on 10 Nov 2011 at 1:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Absolutely amazing.

Original comment by ad...@zetaprints.com on 10 Nov 2011 at 6:11

GoogleCodeExporter commented 9 years ago 
Diff: http://code.google.com/p/magento-w2p/source/detail?r=1834

Original comment by Anatoly....@gmail.com on 12 Nov 2011 at 7:54

GoogleCodeExporter commented 9 years ago 
Please, re-test it with 1.9.2.0alpha16 release (already installed on 
/mageimage/)

Original comment by Anatoly....@gmail.com on 14 Nov 2011 at 5:39

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha16 (alpha) 

Make the table cells show only if the corresponding value is enabled. This 
product:
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
only has PDF output enabled, yet both JPG and PNG table cells are shown empty 
(page_size_01.png).

PDF size is shown regardless, which I think is ok. PDF size shows when the page 
size table is enabled weather PDF output is enabled or not.

Original comment by agur...@gmail.com on 15 Nov 2011 at 9:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Anatoly, can you just check if there are actually any values before adding a 
column?
We can make the template XML a bit friendlier in this respect, but I don't see 
a problem with it as is. Need your opinion.

Original comment by ad...@zetaprints.com on 16 Nov 2011 at 1:09

GoogleCodeExporter commented 9 years ago 
I think it's a bug in ZP

Template details contain Download attr and GenrateXXX attrs (allow-xml.png) 
then download is enabled (allow-setting.png)

And they don't contain such attrs (deny-xml.png) then only download option is 
disabled (deny-setting.png)

Original comment by Anatoly....@gmail.com on 16 Nov 2011 at 6:24

Attachments:

GoogleCodeExporter commented 9 years ago 
These GenerateXXX attributes are conditional to @Download attribute being set 
to ALLOW or ONLY.

I can easily remove this condition, but will it impact on users downloading 
files after ordering?
In other words, if GeneratePDF="1" and Download="" will it allow users download 
the PDF?
It shouldn't.

Need this confirmed before I implement the change. It will affect all existing 
mage sites. Gotta be careful here.

Original comment by ad...@zetaprints.com on 16 Nov 2011 at 9:52

GoogleCodeExporter commented 9 years ago 
OK, I made the change outlined above.

We need to make sure that it doesn't affect how users download files.
It may be possible now that users either get to download files where they 
shouldn't.
Please, check it ASAP as it affects all sites.

Original comment by ad...@zetaprints.com on 16 Nov 2011 at 10:26

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 16 Nov 2011 at 10:26

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 16 Nov 2011 at 2:12

GoogleCodeExporter commented 9 years ago 
I checked it on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha16 (alpha) 

Customer get no links to files when download permission is set to "deny". I 
recon we're OK.

This is the behavior:
- No links if download permission is set to "Deny"
- Links available is download permission is set to "Allow"
- Download permissions must be followed by a "Template sync" profile run for 
the changes to take affect
- Settings affect old orders as well. Download links appear for old orders 
after changing download permission to "allow" and synching the templates.

Original comment by agur...@gmail.com on 17 Nov 2011 at 1:47

GoogleCodeExporter commented 9 years ago 
Please, re-test with 1.9.2.0beta16 release

Original comment by Anatoly....@gmail.com on 20 Nov 2011 at 5:32

GoogleCodeExporter commented 9 years ago 
tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0beta16 (beta)

Original comment by agur...@gmail.com on 21 Nov 2011 at 9:57

GoogleCodeExporter commented 9 years ago 
I don't believe it!

Original comment by ad...@zetaprints.com on 21 Nov 2011 at 10:12