search

Letractively / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

In preview editing fails on Chrome. #653

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Point Chrome at 
http://test.winanelection.com/default/postcards/political-campaign-postcard-hit-
100.html and try to upload an image
2. F5 to refresh the screen
3. Try again

What is the expected output? What do you see instead?

Image upload widget is expected. Just get a title bar first time. Works second 
time.

See attached image for screenshot of error console.

Original issue reported on code.google.com by steve.ho...@gmail.com on 11 Sep 2011 at 9:35

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 11 Sep 2011 at 10:53

GoogleCodeExporter commented 9 years ago 
Errors from the image above mean that some ZP JS files wasn't loaded or jQuery 
object was reloaded.

Original comment by Anatoly....@gmail.com on 14 Sep 2011 at 6:39

GoogleCodeExporter commented 9 years ago 
I did following:

1. Uploaded first image
2. Reloaded page by pressing F5
3. Uploaded second image
4. Clicked on Your photo shape and its editor opened without problems.

Tried to do same with shape editor - same result.

Original comment by Anatoly....@gmail.com on 14 Sep 2011 at 6:47

GoogleCodeExporter commented 9 years ago 
Are you saying you cannot replicate the problem?

Original comment by ad...@zetaprints.com on 14 Sep 2011 at 9:10

GoogleCodeExporter commented 9 years ago 
Are you saying you cannot replicate the problem?

Original comment by ad...@zetaprints.com on 14 Sep 2011 at 9:10

GoogleCodeExporter commented 9 years ago 
Yes, I can't. But maybe I was doing smth wrong?

Original comment by Anatoly....@gmail.com on 14 Sep 2011 at 11:39

GoogleCodeExporter commented 9 years ago 
Why are comments made by return of email not added to this???

1. This is a transient problem - ie external factors affect this.
2. I sent this screenshot because it was failing at the time. First image 
upload attempt caused the errors as described. A refresh and the problem went 
away. 24 hours later the page was working fine.
3. A page refresh will not magically load a js file if it failed the first 
time, nor change the number of times the jq object is loaded. It may, however 
affect the order in which actions are processed.
4. To quote from a previous email...
If there are multiple document.ready blocks ( which
there are ), and one of them creates an object that another block
modifies ( which it does ), and callbacks are relied upon ( which they
are ). then this may happen. as they all run asynchronously - and
external factors, such as the performance of a ZP server will affect.

This has never happened to me in ff or even ie on the few times I've
ever touched it. But it *DOES* regularly happen with chrome.

Original comment by steve.ho...@gmail.com on 14 Sep 2011 at 9:19

GoogleCodeExporter commented 9 years ago 
Anatoly, do we have a single entry point or are there multiple document.ready 
in w2p?
Makes sense to check for dependencies first.

Original comment by ad...@zetaprints.com on 15 Sep 2011 at 12:51

GoogleCodeExporter commented 9 years ago 
> Anatoly, do we have a single entry point or are there multiple document.ready 
in w2p?
>Makes sense to check for dependencies first.

There's only 2 document.ready in w2p. But they're independent

Original comment by Anatoly....@gmail.com on 15 Sep 2011 at 5:42

GoogleCodeExporter commented 9 years ago 
This site also uses fixed prices.

Original comment by steve.ho...@gmail.com on 15 Sep 2011 at 6:50

GoogleCodeExporter commented 9 years ago 
There is only one dependency between fixed qty and w2p as far as I can remember.
Fixed qty is checking for w2p presence to align the button.
I suspect we need to remove invalid HTML from fixed qty and the button will 
stay where it should be.

Original comment by ad...@zetaprints.com on 15 Sep 2011 at 7:18

GoogleCodeExporter commented 9 years ago 
OK, I will check the code of FixedQty ext.

Original comment by Anatoly....@gmail.com on 15 Sep 2011 at 8:17

GoogleCodeExporter commented 9 years ago 
I can't replicate it. 
Steve, can you still replicate it?
We have 2 document.ready, but the second one is completely independent from the 
main one.
A bit at a loss. Not being able to replicate doesn't help.
The thing is - it did happen to me in FF at least once when I tried it first.

Original comment by ad...@zetaprints.com on 16 Sep 2011 at 10:27

GoogleCodeExporter commented 9 years ago 
As we speak, it is not working properly. On firefox all is sweet, but to 
display the in-preview editing, you either need to refresh the screen, or input 
a field in the form to get it to display properly in chromium. Ronnie reports 
the same problem in IE.

I attach a screenshot from chromium, with the javascript error console 
displayed.

Original comment by steve.ho...@gmail.com on 20 Sep 2011 at 12:23

Attachments:

GoogleCodeExporter commented 9 years ago 
Anatoly, let's give it another good look.

Original comment by ad...@zetaprints.com on 20 Sep 2011 at 1:11

GoogleCodeExporter commented 9 years ago 
Atanas, can you replicate the problem?
I can't. It works for me every time.

Original comment by ad...@zetaprints.com on 20 Sep 2011 at 1:02

GoogleCodeExporter commented 9 years ago 
Anatoly, can we act on the info Steve provided or do we need to replicate it?
It does happen, no question about that.

Original comment by ad...@zetaprints.com on 20 Sep 2011 at 1:03

GoogleCodeExporter commented 9 years ago 
As discussed: let's insert pre-checks and disable functionality if some of the 
resources are not loaded. Atanas, we still need it double-checked in case you 
spot the errors.

Original comment by ad...@zetaprints.com on 20 Sep 2011 at 1:32

GoogleCodeExporter commented 9 years ago 
It was working perfectly, *UNTIL* I was talking with Ronnie and discussing 
stuff on the site. It's not some kind of multi-user problem in the backend is 
it??

Original comment by steve.ho...@gmail.com on 20 Sep 2011 at 9:29

GoogleCodeExporter commented 9 years ago 
... or because we have multiple browsers opening the same site on the same 
client machine??

Original comment by steve.ho...@gmail.com on 20 Sep 2011 at 9:31

GoogleCodeExporter commented 9 years ago 
Nah, can;t be. There is no difference in available functionality. The content 
may be different for different users, but it's the same set of JS files loading 
up anyway.
We are inserting pre-checks checks.

The IE problem Ronnie reported wasn't a problem at all, unless I missed 
something. It was about shapes being highlighted in IE on opening of the 
editor, which may happen if the fields already have values.

Original comment by ad...@zetaprints.com on 20 Sep 2011 at 9:54

GoogleCodeExporter commented 9 years ago 
Diff: http://code.google.com/p/magento-w2p/source/detail?r=1798

Original comment by Anatoly....@gmail.com on 21 Sep 2011 at 7:24

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 22 Sep 2011 at 11:20

GoogleCodeExporter commented 9 years ago 
Please, try 1.9.2.0alpha2 release.

Original comment by Anatoly....@gmail.com on 25 Sep 2011 at 6:06

GoogleCodeExporter commented 9 years ago 
I'm not able to replicate this problem. I have encountered the bug before, as 
part of other issues, but it's been a while since I've seen it.

No problems uploading images in Chrome using InPrev. I tried it on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha2 (alpha)

The thing is, I tried to see the difference by testing on an older instance 
(magedev) which is web_to_print_store_incl_theme 1.9.2.0alpha1. 
We still have this customers' templates in there:
http://d1.zetaprints.com/magedev/index.php/political-candidates/postcard-12.html
Works fine for me or I'm missing something. Not flagging it as Test OK yet 
because there might be some other provocation that I can try to replicate the 
err on an old w2p ext version and then confirm that the same scenario doesn't 
throw an err in latest alpha. Suggestions?

Original comment by agur...@gmail.com on 26 Sep 2011 at 6:35

GoogleCodeExporter commented 9 years ago 
I guess we need to deploy it the customer's site and see if they still see it 
happening.

Original comment by ad...@zetaprints.com on 26 Sep 2011 at 9:34

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 3 Oct 2011 at 10:12