Letractively / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

FitInField frame position moves on re-open #671

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha7 (alpha)

FitInField frame moves cached position on FancyBox re-open. Replication 
instructions:
- Navigate to 
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
- Upload or open the image editor for one of the images in your library
- Use the FitInField frame to select a distinctive area that you can remember 
exactly. Like the three windows in this image (01.png)
- Save the selection. The FancyBox will close it self on Save.
- Click on the image thumb to open the image editor again. The previous 
selection has moved up by it self (02.png).

Original issue reported on code.google.com by agur...@gmail.com on 11 Oct 2011 at 6:10

GoogleCodeExporter commented 9 years ago
It shouldn't close on save, to begin with.

Original comment by ad...@zetaprints.com on 12 Oct 2011 at 12:08

GoogleCodeExporter commented 9 years ago
Diffs: http://code.google.com/p/magento-w2p/source/detail?r=1819

Original comment by Anatoly....@gmail.com on 25 Oct 2011 at 5:37

GoogleCodeExporter commented 9 years ago
Please, test it with 1.9.2.0alpha11 release (already installed on /mageimage/)

Original comment by Anatoly....@gmail.com on 26 Oct 2011 at 7:52

GoogleCodeExporter commented 9 years ago
Seems to be working.

Original comment by ad...@zetaprints.com on 26 Oct 2011 at 7:09

GoogleCodeExporter commented 9 years ago
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha11 (alpha)

Bug remains. I tested in all browsers my cache and cookies were cleared a few 
time during the testing.

- http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
- Selected area "4" in the ImgEditor (img_01.png) and closed it
- Thumb was also out of place (img_02.png)
- Re-opened the image in the editor, the selected area moved (img_03.png)
- The coordinates are saved correct, though. Updated the preview after 
re-opening (no saves) and the right part of the image was in the generated 
preview (img_04.png).

Seemed like the dislocation of the selected area somehow depends on which part 
of the image I select. Selecting from the middle row of numbers makes it more 
out of place on re-open than selecting from the bottom row. Just a note, if it 
helps.

Original comment by agur...@gmail.com on 27 Oct 2011 at 12:42

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 1 Nov 2011 at 6:03

GoogleCodeExporter commented 9 years ago
Please, test it with 1.9.2.0alpha12 release (installed on /mageimage/)

Original comment by Anatoly....@gmail.com on 1 Nov 2011 at 6:44

GoogleCodeExporter commented 9 years ago
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.2.0alpha12 (alpha)

No selection movement on re-open. Thumbs bug is separate issue (#674)

Discuss:
Currently the fit-in-field selection is not cached, I wonder if it should be. 
If a user selects an area from a image using fit-in-field feature, updates the 
preview and leaves the product page. Should the selected area get cached and 
stay selected by default when the user comes back to the product?
- Will come useful for re-ordering
- Will be a problem to cache selections per template and per field, since 
fit-in-field edits are dependent on each fields specific dimensions.

Original comment by agur...@gmail.com on 1 Nov 2011 at 3:18

GoogleCodeExporter commented 9 years ago
Good point. It should be cached. The data is in the user cache in ZP, so mage 
has it.

Units?

Original comment by ad...@zetaprints.com on 1 Nov 2011 at 6:38

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 7 Nov 2011 at 8:27

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 12 Nov 2011 at 6:55