Letractively / rmh-roomreservation-maker

Automatically exported from code.google.com/p/rmh-roomreservation-maker
0 stars 0 forks source link

Email function should accept profile activity request ID #47

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.call the function newFamilyMod($FamilyProfileID, $DateSubmitted)
2.
3.

What is the expected output? What do you see instead?

should include a request id so that the rmh approver can search the modify 
profile request. RMH approver needs the request id. 

Please use labels and text to provide additional information.

Original issue reported on code.google.com by jessicac...@gmail.com on 25 Apr 2012 at 10:27

GoogleCodeExporter commented 9 years ago
also I have this error when i try to call the newFamilyMod function:

( ! ) Fatal error: Call to a member function get_parentlname() on a non-object 
in C:\wamp\www\rmh-reservation-maker\mail\functions.php on line 275

Original comment by jessicac...@gmail.com on 25 Apr 2012 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by alisa.mo...@stjohns.edu on 25 Apr 2012 at 10:46

GoogleCodeExporter commented 9 years ago
Since this issue partly concerns the approver flow, I have some thoughts.

The newFamilyMod function should accept ProfileActivity object, which will 
already include family, and SW information including the date submitted. The 
email needs to be modified such that it includes profile request id (which is 
available in the object as well) for the approver to be able to refer/approve 
that activity change.

The email could have something like: 
Please use the request id 123 to approve/deny the activity. Or, follow the 
link: http://example.com/reservation/activity?type=profile&request=123

where 123 is the request ID and everything else in the URL is same for all 
modification request email.

Original comment by prayas.b...@stjohns.edu on 26 Apr 2012 at 9:20

GoogleCodeExporter commented 9 years ago
not certain if this is still a problem

Original comment by bkmackellar on 2 Sep 2012 at 7:10

GoogleCodeExporter commented 9 years ago

Original comment by bkmackellar on 22 Sep 2012 at 7:35