Bogus log warning message?

[GoogleCodeExporter]

Seeing "Unable to create a pid file. You must use mongrel or webrick for
this feature" message in the casserver.log upon initialization using the
rubycas-server-ctl script. However, a pid file _is_ created and everything
runs (via webrick) just fine.

These lines in lib/casserver.rb don't make sense to me:

  if $PID_FILE && (CASServer::Conf.server.to_s != 'mongrel' ||
CASServer::Conf.server.to_s != 'webrick')
    $LOG.warn("Unable to create a pid file. You must use mongrel or webrick
for this feature.")
  end

What is the intention here? How could it ever work?

Not a big deal - just annoying to see the warning in the log for no
apparent reason. Or am I missing something?

rubycas-server-0.5.0.193

Original issue reported on code.google.com by doug.eve...@gmail.com on 6 Dec 2007 at 6:12

[GoogleCodeExporter]

Just caught that myself a few days ago. You're right, the boolean check is 
totally
wrong. It should be:

if $PID_FILE && !(CASServer::Conf.server.to_s == 'mongrel' ||
CASServer::Conf.server.to_s == 'webrick')

I'm in the process of moving all of these Camping wrappers into a separate 
library
(Picnic -- http://code.google.com/p/camping-picnic/) and the fix has been made 
there.
Next step will be to retrofit RubyCAS-Server to use the Picnic stuff, so this 
bogus
warning will be fixed then.

Original comment by matt.zuk...@gmail.com on 6 Dec 2007 at 6:09

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Looking forward to camping-picnic!

Thanks.

Original comment by doug.eve...@gmail.com on 6 Dec 2007 at 9:18

[GoogleCodeExporter]

Fixed in svn now that we've switched over to Picnic.

Original comment by matt.zuk...@gmail.com on 21 Dec 2007 at 8:41

• Changed state: Fixed