search

Letractively / svgweb

Automatically exported from code.google.com/p/svgweb
Other
0 stars 0 forks source link

Make sure SVG Web works in iframes #368

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
First, this library is rockin' awesome!!!

What steps will reproduce the problem?
1.
Create a test page that uses one of the samples in an iframe.
For example,
<html>
  <head>
  </head>
  <body>
    <iframe width="250" height="250" src="demo.html?
name=photos&svg.render.forceflash=true"></iframe>
  </body>
</html>

What is the expected output? 
I would expect the page in the iframe to show pretty much the same as if 
you just did the page itself 
(http://<YOUR_WEB_SERVER>/projects/svgweb/samples/demo.html?
name=photos&svg.render.forceflash=false). This would be pretty important 
towards usage of this library in gadget frameworks.

What do you see instead?
It works fine in firefox. In internet explorer, I get an error line 0 
(dynamic script) indicating that top.svgweb.handlers is undefined. I would 
assume this is due to the code block on line 6229. Specifically, I'm not 
sure you really want to go to the top window in the heirarchy, but instead 
maybe just the parent?

What version of the product are you using? 
On what operating system, browser, and version of Flash?
  Operating System: Windows XP SP3
  Library version: svgweb-2009-10-12-Beholder
  Browser: Internet Explorer
  IE version: 7.0.5730.11
  Flash version: 10.0.22.87

Original issue reported on code.google.com by Aberwyv...@gmail.com on 26 Oct 2009 at 3:05

GoogleCodeExporter commented 8 years ago 
Issue 374 has been merged into this issue.

Original comment by grick23@gmail.com on 3 Nov 2009 at 3:10

GoogleCodeExporter commented 8 years ago

Original comment by bradneub...@gmail.com on 3 Nov 2009 at 3:45

GoogleCodeExporter commented 8 years ago

Original comment by bradneub...@gmail.com on 5 Nov 2009 at 11:53

GoogleCodeExporter commented 8 years ago

Original comment by bradneub...@gmail.com on 5 Nov 2009 at 11:53

GoogleCodeExporter commented 8 years ago 
Hi, 

i had the same problem. so i write the attached patch. I testet it with firefox 
3.6.3 and ie8. Perhaps a developer could review this solution, im not very 
familar with javascript.

Original comment by stefan.s...@gmx.de on 14 Jun 2010 at 11:44

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by bradneub...@gmail.com on 14 Jun 2010 at 5:41

GoogleCodeExporter commented 8 years ago 
Hi!

The patch from stefan didn't work for me. In my case there was no id for the 
iframe and it didn't work.

A quickly typed prototype here (uses svgweb only for IE), but I'm sure you can 
find a more elegant fix for the issue:

http://matti.virtuallypreinstalled.com/vSvgWeb

Original comment by matti.ta...@gmail.com on 23 Jun 2010 at 3:26

GoogleCodeExporter commented 8 years ago 
I've taken a look at the demo site put together by matti and ripped out the 
changes he made to svg.js based on those made by stefan, and reworked them 
slightly into a patch that I've attached.

Original comment by bduncan%...@gtempaccount.com on 23 Jun 2010 at 10:06

Attachments:

GoogleCodeExporter commented 8 years ago 
Fixed in r1261. Thanks for the patch!

Original comment by grick23@gmail.com on 28 Nov 2010 at 10:37