Letractively / swe574-group1

Automatically exported from code.google.com/p/swe574-group1
0 stars 0 forks source link

getIngredients method should accept null criteria #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
As clients, we need an interface which returns all foods from the database 
without giving any criteria. Therefore, getIngredients should accept null 
criteria and returns all ingredients available in case querystring argument is 
null.

For more details, refer to API document v3.2 and section 3.2.

"This method searches and returnes all ingredients whose names start with the 
given query string. In case no criter is given ( the queryString parameter left 
blank), the method returns all ingredients specified in the database."

Original issue reported on code.google.com by esinkara...@gmail.com on 20 May 2014 at 5:35

GoogleCodeExporter commented 8 years ago
I sent null criteria to the getIngredients method and I received this error:

"Exception in thread "main" javax.xml.ws.WebServiceException: Method Parameter: 
queryString cannot be null. This is BP 1.1 R2211 violation."

So I decided to define a new method with the signature (please refer to API 
Spec.Doc. 3.3):

getAllIngredients(String token)

This method is in charge of returning all foods in the database. 

This issue is critical.

Original comment by esinkara...@gmail.com on 27 May 2014 at 7:25

GoogleCodeExporter commented 8 years ago
Hi Esin,

We can drop the new method, the newest commit, when deployed should take care 
of null criteria.

Original comment by turkmen...@gmail.com on 29 May 2014 at 8:17

GoogleCodeExporter commented 8 years ago
Hi Caner,

Thanks. Did you commit the changes? I am still receiving the same exception
message.

Esin

Original comment by esinkara...@gmail.com on 29 May 2014 at 12:03

GoogleCodeExporter commented 8 years ago
i just committed but not deployed..

Original comment by turkmen...@gmail.com on 29 May 2014 at 6:44

GoogleCodeExporter commented 8 years ago
Could you also push the changes to the repository please? I need to deploy
them to my local app.server.

Original comment by esinkara...@gmail.com on 29 May 2014 at 9:20

GoogleCodeExporter commented 8 years ago
must be pushed now. as said in another issue page, there was a merge conflict 
yesterday sorry about that. please verify the fix, thank you.

Original comment by turkmen...@gmail.com on 30 May 2014 at 2:04