Letractively / webpasswordsafe

Automatically exported from code.google.com/p/webpasswordsafe
0 stars 0 forks source link

Can't open passwords on iphone #38

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Goto webpasswordsafe from iphone
2. login
3. search for a password
4. click on the password to try to open it, double click doesn't work on iphone

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by broadway...@gmail.com on 21 May 2011 at 1:30

GoogleCodeExporter commented 8 years ago
meant to say iphone

Original comment by broadway...@gmail.com on 21 May 2011 at 1:31

GoogleCodeExporter commented 8 years ago
Yes, same problem on ipad

Original comment by joshdrum...@gmail.com on 23 May 2011 at 6:54

GoogleCodeExporter commented 8 years ago

Original comment by joshdrum...@gmail.com on 25 May 2011 at 4:26

GoogleCodeExporter commented 8 years ago
iOS Safari apparently doesn't like double-clicks (even latest version of 
Ext-GWT framework).  Will have to add an Open Password menu item for 
accessibility in this case it appears.

Original comment by joshdrum...@gmail.com on 25 May 2011 at 4:56

GoogleCodeExporter commented 8 years ago

Original comment by joshdrum...@gmail.com on 26 May 2011 at 3:55

GoogleCodeExporter commented 8 years ago
I was also able to just make it a single click and then it works fine on ipad 
and iphone.  Not sure if there is another benefit to doubleclick that I am not 
aware of?

The following worked for me.

In the PasswordSearchPanel.java file located by digging into the folders src => 
main => java => com => joshdrummond => webpasswordsafe => client => ui on line 
176 you see this:
passwordGrid.addListener(Events.CellDoubleClick,newListener<GridEvent<PasswordSe
archData>>()

Change "Events.CellDoubleClick" to "Events.CellClick" and it will only require 
1 click to see the password. Due to the app being written in Java you will have 
to recompile the app to see the change work.

Original comment by broadway...@gmail.com on 26 May 2011 at 6:57

GoogleCodeExporter commented 8 years ago
There's really no huge added benefit of double click.  My thinking in that 
decision was to prevent people from accidentally clicking a row with single 
click and generating an audit event, a double click is less likely to be an 
accident, especially when using the same code on non-mobile devices that do 
have mouse input.  The above solution definitely works, however for version 1.1 
I'll keep the original design and instead add menu options (that can be invoked 
by single click) to open the selected grid row for compatibility with mobile 
devices.  If a majority of users prefer the single click user interface, I'm 
very open to making that the default action in a future release.

Original comment by joshdrum...@gmail.com on 6 Jun 2011 at 5:38