search

Letractively / wro4j

Automatically exported from code.google.com/p/wro4j
0 stars 0 forks source link

Incremental build support for linters in maven plugin #792

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently the incremental build support is disabled for linters. 

If it would be enabled, the workflow would be this:

* You have lint errors and you run wro4j:jslint (or any other linter mojo). 
* Your build fails (as expected). 
* You don't change anything and run the plugin again. 
* Expected: the build should fail since the lint errors aren't fixed yet. 
  Actual: No changes detected, the build is successful.

I think there is a room for improvement of this use-case. When the build fails, 
the information regarding state of resources (change or unchanged) could be 
cleared. As result, if there are no lint errors, subsequent builds won't do any 
processing and the build will be successful, while if there are lint errors - 
the resources containing lint errors will be processed (even if no change is 
detected) causing the build to fail (as expected).

Original issue reported on code.google.com by alex.obj...@gmail.com on 1 Oct 2013 at 1:38

GoogleCodeExporter commented 9 years ago 
Fixed in branch 1.7.x

Original comment by alex.obj...@gmail.com on 3 Oct 2013 at 8:58

GoogleCodeExporter commented 9 years ago 
Okay, we need to remember to update 
https://code.google.com/p/wro4j/wiki/MavenPlugin to remove: "This flag has 
effect only for 'run' goal. Other goals (ex: jslint, jshint, csslint) will 
ignore it, since linting need consistent validation results."

Original comment by cow...@bbs.darktech.org on 3 Oct 2013 at 3:23

GoogleCodeExporter commented 9 years ago 
Yes, but only after the new version is released.
Could you try with the latest stable version (branch 1.7.x) and provide some 
early feedback?

Original comment by alex.obj...@gmail.com on 3 Oct 2013 at 3:24

GoogleCodeExporter commented 9 years ago 
Alex,

If you release a snapshot version to Maven Central I'll give it a try.

Original comment by cow...@bbs.darktech.org on 30 Oct 2013 at 2:41

GoogleCodeExporter commented 9 years ago 
Alex, don't you have to update the documentation now that this feature is 
released?

Original comment by cow...@bbs.darktech.org on 6 Jan 2014 at 9:48

GoogleCodeExporter commented 9 years ago 
I will update it tomorrow and will let you know. Until then, the issue
description can be used as a documentation.

support for linters in maven plugin

released?

Original comment by alex.obj...@gmail.com on 6 Jan 2014 at 10:00

GoogleCodeExporter commented 9 years ago 
Sure.

Original comment by cow...@bbs.darktech.org on 6 Jan 2014 at 10:08

GoogleCodeExporter commented 9 years ago 
The documentation has been updated: 
https://code.google.com/p/wro4j/wiki/MavenPlugin

There is no much difference, the only thing to notice is that 
incrementalBuildEnabled flag now also support linting goals.

Original comment by alex.obj...@gmail.com on 7 Jan 2014 at 8:19

GoogleCodeExporter commented 9 years ago 
Thanks Alex ;)

Original comment by cow...@bbs.darktech.org on 7 Jan 2014 at 2:24