LetsLunch / lunch

Other
38 stars 3 forks source link

don't use ids in css #62

Closed cameron closed 10 years ago

cameron commented 10 years ago

https://github.com/LetsLunch/lunch/blob/development/app/templates/profile.html#L6 https://github.com/LetsLunch/lunch/blob/development/app/styles/main.css

ids are too specific — it's nearly impossible for a class style to override an id style, which encourages use of !important, which is not to be encouraged (especially in a large codebase where developers rely on the cascade behavior that !important clobbers).

zzmp commented 10 years ago

Rajat has been updating the styles, so I am assigning this to him.

Omkar, you should be reviewing the code Rajat writes to make sure it fixes these issues.

If your style changes do not fix all occurrences, please fix them in a separate fix branch.