LetsMesh / Site

Repository for the Website named Let's Mesh
https://letsmesh.vercel.app
6 stars 2 forks source link

Leaf/a5.1 input change education #314

Closed Seisigh closed 8 months ago

Seisigh commented 9 months ago

Resolves: #27

Features

Implementation

Group Accordion

Error

Add Accordion

Types

What you should see

The group accordion for education. image_2023-10-04_220444419

The modal for adding new accordions. image

Error for adding a new accordion. image image

Custom Input. image

Added two new accordions with the add button. image

JRSiwiecki commented 9 months ago

I haven't started a review yet, but from a brief look at the description and screenshots, shouldn't there be a way to input and display start and end dates?

Darren52BT commented 9 months ago

I haven't started a review yet, but from a brief look at the description and screenshots, shouldn't there be a way to input and display start and end dates?

It does make a lot of sense to include that but I don't see anything talking about dates on the issue or in the figma. Perhaps that could be done in another issue?

JRSiwiecki commented 9 months ago

I haven't started a review yet, but from a brief look at the description and screenshots, shouldn't there be a way to input and display start and end dates?

It does make a lot of sense to include that but I don't see anything talking about dates on the issue or in the figma. Perhaps that could be done in another issue?

Possibly. The start and end dates were added retroactively anyways, so another issue is probably fine. (Would either of you mind making the issue pllllllllleeeeeeeeeeeaseeeeeee 🥺)

Darren52BT commented 9 months ago

I haven't started a review yet, but from a brief look at the description and screenshots, shouldn't there be a way to input and display start and end dates?

It does make a lot of sense to include that but I don't see anything talking about dates on the issue or in the figma. Perhaps that could be done in another issue?

Possibly. The start and end dates were added retroactively anyways, so another issue is probably fine. (Would either of you mind making the issue pllllllllleeeeeeeeeeeaseeeeeee 🥺)

done 👍 #315