LetsMesh / Site

Repository for the Website named Let's Mesh
https://letsmesh.vercel.app
6 stars 2 forks source link

[Refactor] Unified Home Routing with App Layout & User Context #353

Closed blu3eee closed 3 weeks ago

blu3eee commented 3 weeks ago

**Note: This should be the last frontend refactoring for the issue #346

Currently, we have separated Header (logged in/out header, logged in/out footer, and 2 routes logged_in_home and logged_out_home). I want to introduce user context that will change when user is logged in and the components will display accordingly.

PR changes:

This PR should resolves:

Please review it and let me know if these changes are reasonable. Thank you!

Demo for the changes:

https://github.com/LetsMesh/Site/assets/88558991/50c8fff0-06d3-489d-a3ce-3bbb3f315164

Darren52BT commented 3 weeks ago

I think most of the changes are good though I'm a bit confused on what you intend GridContainer to do since I see you overriding the justify-content and align-items props that you set for it here. image image

Upon testing though everything looks good.

blu3eee commented 3 weeks ago

skimmed thru the issues and realized this PR also resolved some of the bugs: #324 and #325