LettError / designSpaceRoboFontExtension

A RoboFont extension for creating and editing designspace documents.
MIT License
29 stars 6 forks source link

Display & save floating-point numbers for rules #14

Closed thundernixon closed 2 years ago

thundernixon commented 5 years ago

I've noticed that the Rules tab displays rules, but rounds to integers.

In some axes like ital that must be 0–1, this blocks rule functionality.

For example, I assert roman glyph forms when:

designspace rule XML (Click to expand) ``` ```

However, this information displays like this:

image

image

And if I save it, it overwrites the floating-point values with integers, disrupting functionality.

Unless I'm doing something I shouldn't be doing, this seems like it would be a worthwhile change to make.

Thanks for making another useful tool!

thundernixon commented 5 years ago

I thought that maybe changing...

https://github.com/LettError/designSpaceRoboFontExtension/blob/eb420123bb5cdd5eedbcaf1ca51308283ff4096f/DesignSpaceEditor.roboFontExt/lib/designSpaceEditorwindow.py#L1808-L1834

...from int() to float() might solve this, but it still rounds values. I'd be curious to learn what causes this issue. 🤔

typemytype commented 2 years ago

the new DS5 editor has improved rule editor based