search

Leuchtfeuer / locate

The users country and preferred language and other facts will be detected. Depending on configurable rules the user can be redirected to other languages or pages. New functionality can be added easily.
https://www.Leuchtfeuer.com
GNU General Public License v2.0
9 stars 14 forks source link

Going without a decision/verdict should not trigger an error-logging #43

Closed neufeind closed 11 months ago

neufeind commented 1 year ago

We have a judge (based on AbstractJudge) that checks if some redirects should take place. If not it simply returns $this without setting a decision/verdict. In court.php that triggers:

No verdict should be delivered. This might be a problem in you configuration

That happens if decision is not set or if the verdict is not set. Imho it should be possible to take no decision. Otherwise we'd maybe need a "null-decision"?

davkraid commented 11 months ago

Good point. It's also a problem for the Condition Judge because if there is no matching condition and no Fixed Judge set, is also triggers the error logging. Thanks for your PR!