Closed vweevers closed 6 years ago
I prefer the key-value check, it covers more ground. Because if no arguments are passed, then key === undefined && value === undefined
is also true.
@ralphtheninja WDYT?
This might be a good time to officially drop undefined
(perhaps also null
) as keys and values (#120).
I prefer the key-value check, it covers more ground.
In fact that's already how we test it in abstract-leveldown
:
In other words, no change is required in abstract-leveldown
, but since we aren't supporting undefined
anyway, we should make that official.
@ralphtheninja reopen if you disagree.
From https://github.com/Level/concat-iterator/issues/1#issuecomment-399747452:
And