search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Should level-concat-iterator be a dependency? #248

Closed vweevers closed 6 years ago

vweevers commented 6 years ago

Otherwise implementations that use the default testCommon must include level-concat-iterator as a devDependency themselves.

https://github.com/Level/abstract-leveldown/blob/029f56acb2123944045430c54a2fdbdfb69da8d4/package.json#L19-L21

vweevers commented 6 years ago

If not, we should at least document these implicit peer dependencies.

ralphtheninja commented 6 years ago

Hmm, this is quite annoying :) We should probably change this to a dependency then, since it should be enough for an implementation to depend on abstract-leveldown imo.

vweevers commented 6 years ago

I'll do that as part of #240, as it's the same story with tempy.