search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Use tempy in testCommon #249

Closed vweevers closed 6 years ago

vweevers commented 6 years ago

Closes #240, closes #248, closes #177.

vweevers commented 6 years ago

Note regarding removal of testCommon.cleanup: leveldown and friends use it, but they don't have to anymore after this. See https://github.com/Level/leveldown/issues/491

ralphtheninja commented 6 years ago

What happened with the browser tests there?

vweevers commented 6 years ago

image

😨

vweevers commented 6 years ago

Ah, of course, the browser tests require testCommon. Need to add a browserify exclusion for tempy.

vweevers commented 6 years ago

Better yet, use a custom testCommon in browsers.