Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Update upgrade guide #262

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 6 years ago

We need to rewrite the upgrade guide for the currently unreleased functionality, since test/common is now both for node and the browser (empty setUp() and tearDown()).

See discussion in #258

ralphtheninja commented 6 years ago

So some of these are no longer relevant, given that test/common will be removed.

vweevers commented 6 years ago

Can skip "removed deprecated module.exports.snapshot test" because that hasn't been released yet.

ralphtheninja commented 6 years ago

Same for errorValues test. Only seek stuff left for now.

vweevers commented 6 years ago

Ticked off the rest of the boxes to see what's done. Added chained batch + collectEntries.

ralphtheninja commented 6 years ago

Added note on test/close-test.js

vweevers commented 6 years ago

That's another internal detail, no?

ralphtheninja commented 6 years ago

That's another internal detail, no?

True. I was just thinking that some implementations are currently calling .close(). Maybe explaining about a single test function is enough?

vweevers commented 6 years ago

All implementations should no longer require() the individual tests, so we don't have to explain changes we make to those internals :)

vweevers commented 6 years ago

Added a task for #277.

vweevers commented 6 years ago

Added: Remove "Empty errorValues() test was removed" ;)