Closed ralphtheninja closed 6 years ago
So some of these are no longer relevant, given that test/common
will be removed.
Can skip "removed deprecated module.exports.snapshot test" because that hasn't been released yet.
Same for errorValues
test. Only seek
stuff left for now.
Ticked off the rest of the boxes to see what's done. Added chained batch + collectEntries.
Added note on test/close-test.js
That's another internal detail, no?
That's another internal detail, no?
True. I was just thinking that some implementations are currently calling .close()
. Maybe explaining about a single test function is enough?
All implementations should no longer require()
the individual tests, so we don't have to explain changes we make to those internals :)
Added a task for #277.
Added: Remove "Empty errorValues() test was removed" ;)
We need to rewrite the upgrade guide for the currently unreleased functionality, since
test/common
is now both for node and the browser (emptysetUp()
andtearDown()
).factory
and pass intestCommon
testCommon
parameter no longer has default value (NYI)seek
test/common
is a function (NYI)removed deprecatedmodule.exports.snapshot
test (NYI)removed emptyerrorValues
test (NYI)testCommon.collectEntries
test/close-test.js
updated withsetUp
andtearDown
(https://github.com/Level/abstract-leveldown/pull/279)See discussion in #258