Closed ralphtheninja closed 6 years ago
Previously we often just used testCommon.js from abstract-leveldown and passed it in to abstract tests and it made sense at the time to make it a default parameter, e.g.
testCommon.js
abstract-leveldown
module.exports.all = function (test, testCommon) { testCommon = testCommon || require('./common') // .. }
This doesn't really make much sense now since all implementations are forced to pass in their own testCommon due to factory function etc.
testCommon
Done.
Previously we often just used
testCommon.js
fromabstract-leveldown
and passed it in to abstract tests and it made sense at the time to make it a default parameter, e.g.This doesn't really make much sense now since all implementations are forced to pass in their own
testCommon
due to factory function etc.