search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Remove default testCommon parameter #264

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 6 years ago

Previously we often just used testCommon.js from abstract-leveldown and passed it in to abstract tests and it made sense at the time to make it a default parameter, e.g.

module.exports.all = function (test, testCommon) {
  testCommon = testCommon || require('./common')
  // ..
}

This doesn't really make much sense now since all implementations are forced to pass in their own testCommon due to factory function etc.

ralphtheninja commented 6 years ago

Done.