search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Update upgrade guide [wip] #272

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 6 years ago

I was thinking we could keep this branch alive and tweak the upgrade guide separately as we go. Then just squash it on top of everything, once we're done.

ralphtheninja commented 6 years ago

@vweevers Lets tweak this ^ until we're happy with it and then maybe you could write something about seek after that? (Well, doesn't have to be done in that order since seek doesn't conflict with the current changes).

vweevers commented 6 years ago

I was thinking we could keep this branch alive and tweak the upgrade guide separately as we go. Then just squash it on top of everything, once we're done.

Nice idea. Avoids getting into merge conflicts every time

vweevers commented 6 years ago

The "Default testCommon is for disk-based, Node.js implementations only" section can be removed.

ralphtheninja commented 6 years ago

The "Default testCommon is for disk-based, Node.js implementations only" section can be removed.

Aaah right. I was moving stuff around and forgot about it.

ralphtheninja commented 6 years ago

So I guess we need to rewrite this again :wink:

vweevers commented 6 years ago

The diff is a bit ugly because so much changed.

ralphtheninja commented 6 years ago

The diff is a bit ugly because so much changed.

It's fine. I just read the green :) Btw, I can't review since I made the PR. LGTM!

ralphtheninja commented 6 years ago

LGTM

vweevers commented 6 years ago

Will fill the empty sections later.

vweevers commented 6 years ago

@ralphtheninja done, PTAL. I'll rebase on top of master afterwards, because it's becoming painful not being able to browse the code while working on the upgrade guide.

ralphtheninja commented 6 years ago

@ralphtheninja done, PTAL. I'll rebase on top of master afterwards, because it's becoming painful not being able to browse the code while working on the upgrade guide.

LGTM. Go!

ralphtheninja commented 6 years ago

@vweevers Maybe squash this on top of master now?