Closed ralphtheninja closed 6 years ago
@vweevers Lets tweak this ^ until we're happy with it and then maybe you could write something about seek
after that? (Well, doesn't have to be done in that order since seek
doesn't conflict with the current changes).
I was thinking we could keep this branch alive and tweak the upgrade guide separately as we go. Then just squash it on top of everything, once we're done.
Nice idea. Avoids getting into merge conflicts every time
The "Default testCommon is for disk-based, Node.js implementations only" section can be removed.
The "Default testCommon is for disk-based, Node.js implementations only" section can be removed.
Aaah right. I was moving stuff around and forgot about it.
So I guess we need to rewrite this again :wink:
The diff is a bit ugly because so much changed.
The diff is a bit ugly because so much changed.
It's fine. I just read the green :) Btw, I can't review since I made the PR. LGTM!
LGTM
Will fill the empty sections later.
@ralphtheninja done, PTAL. I'll rebase on top of master afterwards, because it's becoming painful not being able to browse the code while working on the upgrade guide.
@ralphtheninja done, PTAL. I'll rebase on top of master afterwards, because it's becoming painful not being able to browse the code while working on the upgrade guide.
LGTM. Go!
@vweevers Maybe squash this on top of master now?
I was thinking we could keep this branch alive and tweak the upgrade guide separately as we go. Then just squash it on top of everything, once we're done.