search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

tests: Move level-concat-iterator to optional #366

Closed Raynos closed 4 years ago

Raynos commented 4 years ago

This means that it's only required for testing and not a production dependency.

I've added a human readable error with instructions on how to fix it for the users of this package.

vweevers commented 4 years ago

I'm not a fan of optionalDependencies. They're ambiguous, and npm ignores installation failures.

I think I would prefer moving the test suite to its own package (not sure how that should be versioned). Also because I've recently been bringing the abstract-leveldown and levelup test suites & interfaces closer together (there are now abstract-leveldown implementations that call the levelup test suite, and vice versa), with the ultimate goal of having one test suite.

Raynos commented 4 years ago

Cool.

Raynos commented 4 years ago

I mean; thanks for taking a look. It’s hard to maintain something used by so many modules.

We appreciate the maintenance.