search

Level / abstract-leveldown

An abstract prototype matching the leveldown API.
MIT License
146 stars 53 forks source link

Added code to run on Power systems #371

Closed genisysram closed 3 years ago

genisysram commented 3 years ago

Hi Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

vweevers commented 3 years ago

Thanks for the PR. My response is the same as https://github.com/browserify/node-util/pull/53#issuecomment-744564852:

Nothing about this package (or any pure-JS package that doesn't touch the filesystem) can vary based on architecture, so testing in other architectures is not valuable.

On abstract-leveldown we can guarantee we'll never introduce dependencies with native addons, or touch the filesystem, because abstract-leveldown is an abstract interface that targets both node and browsers.

Testing against ppc64le would be valuable on native addons like https://github.com/Level/leveldown.