Level / community

Discussion, support and common information for projects in the community.
MIT License
43 stars 15 forks source link

Implement db#clear across the board #79

Closed vweevers closed 2 years ago

vweevers commented 6 years ago

Background: https://github.com/Level/abstract-leveldown/pull/24#issuecomment-397760287.

Phase 1: get it working

Phase 2: optimize

On the side

ralphtheninja commented 6 years ago

Very nice. I especially like the subleveldown feature, like emptying a bucket of stuff.

vweevers commented 6 years ago

Relevant leveldown issue: https://github.com/Level/leveldown/issues/9.

vweevers commented 6 years ago

Ah, the level-concat-iterator dependency comes in handy for the default implementation of _clear :)

ralphtheninja commented 6 years ago

Ah, the level-concat-iterator dependency comes in handy for the default implementation of _clear :)

Good. Then we don't have to feel so bad about including it :wink:

vweevers commented 6 years ago

Ah, the level-concat-iterator dependency comes in handy for the default implementation of _clear :)

Scratch that. Would choke on many keys.

vweevers commented 5 years ago

Because abstract-leveldown@6.1.0 now has a clear() method, I'm moving this issue to community to track overall progress.