Closed vweevers closed 2 years ago
Similarly, iterator.seek()
and chained batch operations (Level/levelup#633) don't support encoding options. In general, all methods should start following the basic signature fn(..., options, callback)
.
Done in classic-level
(not on npm yet), including for seek()
. I will also add it to rocks-level
, the yet-to-be-written replacement for rocksdb
. These fixes will not be backported to leveldown
or rocksdb
.
If you do:
Then
encoding-down
correctly encodes the start (a
) and end (b
) arguments as JSON, but it also passes the options argument down toleveldown
, which doesn't support that: it expects a callback at that index.Add options to
approximateSize()
andcompactRange()
in:leveldown
rocksdb
leveldown-hyper