Prefer backpressure over snapshot guarantees

Level / level-js

An abstract-leveldown compliant store on top of IndexedDB.

MIT License

544 stars 44 forks source link

Prefer backpressure over snapshot guarantees #86

Closed vweevers closed 2 years ago

vweevers commented 6 years ago

Continuing from https://github.com/Level/level.js/pull/68.

TBD if this should go in v3.

vweevers commented 6 years ago

I'm not sure whether to include this in v3 or exactly how to implement it. It can also be added in a minor later, but the thing that bothers me is that the readme states "Store large amounts of data in modern browsers". You can write large amounts of data, sure, but without backpressure, you're gonna run into trouble when reading.

vweevers commented 6 years ago

@ralphtheninja thoughts?

ralphtheninja commented 6 years ago

I'd skip it for v3 so we can get level-browserify out and later level. Then we can work on the minor as you mentioned.

vweevers commented 5 years ago

Relevant: https://github.com/Level/community/issues/63#issuecomment-455697075 and https://github.com/Level/community/issues/63#issuecomment-455759151. IMO offering proper backpressure is a higher priority now.

vweevers commented 5 years ago

I now prefer that we forgo snapshotting guarantees, in favor of backpressure and avoiding a blocking transaction.

vweevers commented 3 years ago

Plan:

[ ] Implement iterator.all() with snapshot guarantees. This offers a nice alternative.
- See https://github.com/Level/abstract-leveldown/issues/380
[ ] Drop snapshot guarantee from (regular use of) iterators

vweevers commented 2 years ago

Done in browser-level.