search

Level / leveldown

Pure C++ Node.js LevelDB binding. An abstract-leveldown compliant store.
MIT License
775 stars 177 forks source link

Add node 12 to AppVeyor (or check what their schedule is) #630

Closed vweevers closed 5 years ago

vweevers commented 5 years ago

Forked from https://github.com/Level/leveldown/issues/628#issuecomment-489470048

@ralphtheninja

vweevers commented 5 years ago

https://github.com/appveyor/ci/issues/2921#issuecomment-486727727

vweevers commented 5 years ago

I'm fine with waiting for AppVeyor to catch up. If there's an issue on node 12, that'd be a bug in N-API and not ours to fix.

However, just now I tested node 12 on Windows, and it seems that node-gyp-build doesn't find a prebuild. That happens on every node version in fact, so it's (I hope) some problem with my setup because it worked before. Trying to figure out what's going on.

Error: No native build was found for platform=win32 arch=x64 runtime=node abi=72 uv=1 libc=glibc
vweevers commented 5 years ago

Oh, duh, I have prebuilds that were made with the previous version of prebuildify and its naming scheme. Nevermind 😄

vweevers commented 5 years ago

Yeah, with that out of the way, node 12 works fine.