New serialization - Githubissues

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.

MIT License

287 stars 37 forks source link

New serialization #106

Closed vweevers closed 6 years ago

vweevers commented 6 years ago

Do not merge yet.

I can break this PR up but first I wanted to get feedback on the changes as a whole. You can follow the commits, or start with the readme and changelog.

vweevers commented 6 years ago

@ralphtheninja @juliangruber mostly I want to make sure that you're OK with this new direction (of memdown supporting all JS types). Any thoughts or concerns?

ralphtheninja commented 6 years ago

@vweevers Can we get this merged?

vweevers commented 6 years ago

Sure. Lemme:

[x] Address https://github.com/Level/memdown/pull/106#discussion_r154593421
[x] Remove the object keys test
[x] Pin abstract-leveldown to latest commit
[x] Update test suite:
- [x] Remove ranges-test.js
- [x] Add iterator-range-test.js
[x] Open an issue to switch to versioned abstract-leveldown once published => #109
[x] Open an issue to remove _isBuffer => #110
[x] Squash (not all)

vweevers commented 6 years ago

@ralphtheninja do I need to change anything else in the test suite?

vweevers commented 6 years ago

The build failure is probably a random connection error:

W: Failed to fetch http://www.apache.org/dist/cassandra/debian/dists/39x/InRelease  
Could not connect to www.apache.org:80 (140.211.11.105), connection timed out
W: Failed to fetch http://ppa.launchpad.net/chris-lea/redis-server/ubuntu/dists/trusty/InRelease  
Could not connect to ppa.launchpad.net:80 (91.189.95.83), connection timed out

Restarting.