search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

Add nyc and browser code coverage #169

Closed vweevers closed 6 years ago

vweevers commented 6 years ago

Testing https://github.com/airtap/airtap/pull/194. Closes #153.

vweevers commented 6 years ago

Changed Coveralls to fail if coverage drops:

image

vweevers commented 6 years ago

Yes, it works! https://coveralls.io/jobs/37997408

vweevers commented 6 years ago

Note that this setup doesn't test that coverage is 100% in each browser. It's cumulative. E.g. if you have this code:

if (runningInChrome) {
 // do this
} else {
 // do that
}

Coverage would be 50% if you only test Chrome, and 100% if you test Chrome and Firefox.

ralphtheninja commented 6 years ago

Note that this setup doesn't test that coverage is 100% in each browser.

I think that's perfectly fine.

vweevers commented 6 years ago

I agree :)

vweevers commented 6 years ago

Ignore the failed build, I removed the coverage branch from airtap.

vweevers commented 6 years ago

Good to merge, pending travis