search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

major version bump, unpublish 0.11.0 #28

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 9 years ago

the global db store is a breaking change I had some tests that where using throwaway db names but where not destroying, suddenly breaking because each instance isn't fresh

calvinmetcalf commented 9 years ago

may want to combine with #26 as that will also be breaking (i.e. for jsondown)

nolanlawson commented 9 years ago

why is it breaking? I thought "destroy" was pretty standard?

calvinmetcalf commented 9 years ago

But previously if you created a new memdown, with the same location it would be empty even if you didn't destroy the old one On Oct 27, 2014 5:50 PM, "Nolan Lawson" notifications@github.com wrote:

why is it breaking? I thought "destroy" was pretty standard?

— Reply to this email directly or view it on GitHub https://github.com/rvagg/memdown/issues/28#issuecomment-60675679.

nolanlawson commented 9 years ago

right, that was a bug. no other *down database works that way.

I guess it just depends on whether we think people were depending on that bug or not.

calvinmetcalf commented 9 years ago

I mean I was, but more seriously it was a documented feature that the location did not matter for memdown, now it does, it's a good feature but it's a breaking change

nolanlawson commented 9 years ago

fair enough, I'm fine with that

nolanlawson commented 8 years ago

this is done