search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

Use immediate library for asynchronous invokes. #32

Closed ronag closed 9 years ago

juliangruber commented 9 years ago

can you explain why you need this change?

calvinmetcalf commented 9 years ago

I will point out also that the queue system of immediate is now in browserify's process.nextTick, so using immediate is likely no longer an advantage.

On Sun, Apr 5, 2015, 10:00 AM Julian Gruber notifications@github.com wrote:

can you explain why you need this change?

— Reply to this email directly or view it on GitHub https://github.com/rvagg/memdown/pull/32#issuecomment-89776503.

ronag commented 9 years ago

In webpack it is a lot faster. Using pouchdb I get a put -> changes roundtrip of 4-6ms instead of 11-15ms.

calvinmetcalf commented 9 years ago

That seems like an issue to open with Web pack

On Sun, Apr 5, 2015, 12:48 PM Robert Nagy notifications@github.com wrote:

In web pack it is a lot faster.

— Reply to this email directly or view it on GitHub https://github.com/rvagg/memdown/pull/32#issuecomment-89808125.

ronag commented 9 years ago

Fair enough.

calvinmetcalf commented 9 years ago

If you open an issue on Web pack do link to it here

On Sun, Apr 5, 2015, 1:52 PM Robert Nagy notifications@github.com wrote:

Closed #32 https://github.com/rvagg/memdown/pull/32.

— Reply to this email directly or view it on GitHub https://github.com/rvagg/memdown/pull/32#event-273678355.