search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

Minor cleanup #54

Closed nolanlawson closed 8 years ago

nolanlawson commented 8 years ago
coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a13bf781a29020b91bbb837886a548e63f348f4a on cleanup into 8671844e0bdeb233f00be4e4e04823c3a322990f on master.

juliangruber commented 8 years ago

👍

vweevers commented 8 years ago

What will this do to the stack trace of NotFoundErrors?

juliangruber commented 8 years ago

What will this do to the stack trace of NotFoundErrors?

Aaaah good catch! Yeah they would all be the same. Let's not do this optimisation then, but merge in the other changes?

nolanlawson commented 8 years ago

Shoot, that's a very good point. I guess there's no way around allocating the new Errors every time. :/

nolanlawson commented 8 years ago

I'll do the other fixes but remove the NotFoundError stuff.

nolanlawson commented 8 years ago

Just tested it out; the error is indeed more useful if you create a new one every time.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ee3dce8ffbe362400592d16b6cb07bd97f533a5b on cleanup into 8671844e0bdeb233f00be4e4e04823c3a322990f on master.

nolanlawson commented 8 years ago

localtunnel still having a bad day, but hopefully it should be green eventually

nolanlawson commented 8 years ago

Woot, green!