use abstract-leveldown-pouchdb@2.4.3

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.

MIT License

287 stars 37 forks source link

use abstract-leveldown-pouchdb@2.4.3 #56

Closed nolanlawson closed 8 years ago

nolanlawson commented 8 years ago

This is a perf improvement because 2.4.3 avoids allocating an extra NotFoundError. Also this puts us on a fork of abstract-leveldown, which I'm not super happy about, but I don't see a way around it without expending a lot of energy to update to abstract-leveldown 2.6.0 so I preferred to fork.

nolanlawson commented 8 years ago

this also fixes #55 in a sense because we just stop depending on abstract-leveldown

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling b649055a23d0323deb13374d464ee2f444046473 on abstract-leveldown-pouchdb into 8671844e0bdeb233f00be4e4e04823c3a322990f on master.

nolanlawson commented 8 years ago

Backing down from this fork. The only reason I wanted it was to avoid re-allocating NotFoundErrors, but realized that's a bad idea because it wrecks stacktraces (#54), also abstract-leveldown@2.6.1 apparently fixes this problem. Will deprecate abstract-leveldown-pouchdb.