search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

Use immediate in browsers, setImmediate in Node #61

Closed nolanlawson closed 7 years ago

nolanlawson commented 7 years ago

See https://github.com/Level/memdown/pull/59#issuecomment-261004755 for backstory.

calvinmetcalf commented 7 years ago

👍

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8d952e7f982b0dbbf2c921ef566a75a29f2d51ba on immediate2 into 0fb34b3fb2503707e2648a52a2512a936770894e on master.

juliangruber commented 7 years ago

i think this can be simplified by removing immediate-browser.js and having "./immediate.js": "immediate" in the package.json?

nolanlawson commented 7 years ago

@juliangruber The reason I don't do that is that that pattern breaks in Webpack and Rollup. Or at least it used to. So I don't trust it anymore.

juliangruber commented 7 years ago

@juliangruber The reason I don't do that is that that pattern breaks in Webpack and Rollup. Or at least it used to. So I don't trust it anymore.

Meh, ok!