search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

clean up null/undefined check in _put #71

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 7 years ago

https://github.com/Level/memdown/blob/0454e57399616b81fd76acc4f69fe17859be1fe9/memdown.js#L148

Prerequisite: https://github.com/Level/abstract-leveldown/pull/119 has to be released

vweevers commented 6 years ago

@ralphtheninja by clean up you mean remove this line?

ralphtheninja commented 6 years ago

@ralphtheninja by clean up you mean remove this line?

Aye, but only once abstract-leveldown takes care of it, which iirc is not the case now. Also see https://github.com/Level/abstract-leveldown/issues/120

vweevers commented 6 years ago

Actually, abstract-leveldown also does this in _serializeValue, so (at least to maintain current behavior) it's safe to remove this line.

vweevers commented 6 years ago

Removed in #106.