search

Level / memdown

In-memory abstract-leveldown store for Node.js and browsers.
MIT License
287 stars 37 forks source link

feat(typings): add initial typings #76

Closed MeirionHughes closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3975d39e428a6ac24ea335c00ef8f80850747b2f on MeirionHughes:typings into 5b876b1fcaf34a0da26810d8759ba8753f1b6fa9 on Level:master.

ralphtheninja commented 7 years ago

@MeirionHughes I think the browser tests fail because you are doing an external PR, push up the typings branch to upstream instead of your own fork.

MeirionHughes commented 7 years ago

done - do you want me to make a new pr from typings -> master

looks like the tests passed bar one (due to connection error).

ralphtheninja commented 7 years ago

done - do you want me to make a new pr from typings -> master

Sure, it shouldn't really matter with your changes, but lets try to be thorough :)

MeirionHughes commented 7 years ago

ahh... github is actually smart enough to know this commit (id) from my fork is the same as the one in the typings branch (memdown)

image

I've done another one anyway and retriggered the build.