perf: bypass duplexify

[ronag]

Bypasses duplexify and pipes encode, socket, decode directly without any intermediate proxy.

[ronag]

Would be nice if multileveldown provided a less hacky way to do this...

[vweevers]

The goal here is to skip this line, if I understand it correctly? https://github.com/Level/multileveldown/blob/52f4861fc37500bfed167114f007bfce3104fc77/leveldown.js#L79.

[ronag]

The goal here is to skip this line, if I understand it correctly? https://github.com/Level/multileveldown/blob/52f4861fc37500bfed167114f007bfce3104fc77/leveldown.js#L79.

Yep and avoid the overhead and complexity of an intermediate stream.

[vweevers]

The less hacky way would be to support a second argument here, defaulting to null:

https://github.com/Level/multileveldown/blob/52f4861fc37500bfed167114f007bfce3104fc77/client.js#L21-L23

[ronag]

The less hacky way would be to support a second argument here, defaulting to null:

Yep. But that would require updating multileveldown.

[vweevers]

I worry this will have a side effects, because:

• duplexify handles a bunch of edge cases
• the close event on a net socket has a hadError argument that we may need to ignore here

[ronag]

I worry this will have a side effects, because:

• duplexify handles a bunch of edge cases

I'm more worried about having duplexify than not having it.

• the close event on a net socket has a hadError argument that we may need to ignore here

Yes.

[vweevers]

This makes no difference in my benchmarks, at least not after removing much bigger bottlenecks. In rave-level (the WIP replacement for level-party) I doubled the throughput by batching reads, among other things.

[ronag]

Can I follow many-level somewhere?

[vweevers]

I'll post something in https://github.com/Level/abstract-level/issues/14 once I've pushed the repo