search

Level / rocksdb

Pure C++ Node.js RocksDB binding. An abstract-leveldown compliant store.
MIT License
230 stars 54 forks source link

Include prebuilt binary for alpine #174

Closed gogoout closed 3 years ago

gogoout commented 3 years ago

Hi all, Alpine is commonly used in container environment. Currently seems alpine seems doesn't have a prebuilt binary. Not sure if this is a low hanging fruit.

vweevers commented 3 years ago

Assuming that RocksDB compiles against musl (no reason to believe it doesn't), this should be easy. We do the same for leveldown. It's a matter of adding -i alpine to:

https://github.com/Level/rocksdb/blob/5c8e0b9a4519ba8e9a25dc3b704f1bae395af214/package.json#L16

If no one is opposed to increasing npm package size. I'm fine with that.

reuzel commented 3 years ago

Great work!

Is there any ETA for the next release in which this binary will be prepackaged?

vweevers commented 3 years ago

When I have a free moment, within a week.

gogoout commented 3 years ago

Hi, any updates on releasing?

vweevers commented 3 years ago

5.1.0