Build a universal binary to support M1 (Apple silicon)

Level / rocksdb

Pure C++ Node.js RocksDB binding. An abstract-leveldown compliant store.

MIT License

229 stars 53 forks source link

Build a universal binary to support M1 (Apple silicon) #181

Closed Nazgolze closed 2 years ago

Nazgolze commented 2 years ago

Closes #177

Since this change is around cpu architecture and not OS, I did some testing on Ubuntu ARM64. Interestingly, 5.1.0 here did not have the same issue as on the Mac M1. Nevertheless, I've tested this PR on the M1 Mac and Ubuntu ARM64, have not encountered any errors and, so far, it's working well in our app (though the more eyeballs, the better - if @buu700 is able to give this a try as well :pray: )

buu700 commented 2 years ago

Looks good to me, thanks @Nazgolze!

vweevers commented 2 years ago

Can we make this work for a universal binary as well? See https://github.com/Level/leveldown/pull/781 for comparison - I want to do the same for rocksdb

vweevers commented 2 years ago

Note to self: on release, compare prebuild binary size to the previous release

vweevers commented 2 years ago

5.1.1