LevelbossMike / ember-deploy-s3

ember-deploy assets-adapter for amazon s3
MIT License
19 stars 22 forks source link

PROPOSAL - Do not set cache header for uploaded index.html on S3 #6

Closed rtablada closed 9 years ago

rtablada commented 9 years ago

While I understand the project's focus on versioned deploys, but this is actually quite usable in a scenario to simply upload the full site (including index.html) to a flat file service.

When this is the use case, the 2 year cache header on the index.html file means that serving completely from S3 isn't practical since people will only get updates if the break cache (losing benefits of unchanged assets).

LevelbossMike commented 9 years ago

When you decide to deploy to s3 as an index store there's the https://github.com/Kerry350/ember-deploy-s3-index project for that.

You are right that the 2 year cache header does not make much sense and this should be removed. But as I said I strongly recommend the s3-index-adapter if you want to serve the index.html from s3.