Closed georgefst closed 1 year ago
Do these have an extra stray $ at the end of each hint? Looks odd to me. And the hlint check fails on them. See below.
Ah, yes, sorry, I am genuinely unsure how I managed to mess that up. Fixed now.
Thanks for the PR. Regarding your specific questions:
My primary motivation for this is cross-compiling SBV. Before this change, this wasn't possible due to the warning
Ignoring ANN annotation, because this is a stage-1 compiler without -fexternal-interpreter or doesn't support GHCi
, combined with-Werror
. With the change, it's only blocked by #659.Out of interest:
-Werror
? It's unusual to use it everywhere, and Hackage even bans uploading packages which enable it globally, which SBV appears to work around by enabling it in every individual file instead.Data
folder is HLint-clean, butDocumentation
andSBVTestSuite
contain some ignore pragmas but also trigger other hints which aren't ignored. Also, based on the numbers of HLint warnings which remain when all ignore pragmas are removed, many of them are redundant. Maybe putting the pragmas near use sites, as is conventional, would help see when these can be removed (although ideally HLint itself would be able to check this)