OptimizeStyle: add type parameter for the optimize result type

LeventErkok / sbv

SMT Based Verification in Haskell. Express properties about Haskell programs and automatically prove them using SMT solvers.

https://github.com/LeventErkok/sbv

Other

239 stars 33 forks source link

OptimizeStyle: add type parameter for the optimize result type #709

Closed thielema closed 1 month ago

thielema commented 1 month ago

OptimizeResult: split into types LexicographicResult, ParetoResult, IndependentResult Made OptimizeResult a type class. Requires moving definition of OptimizeStyle to Provers.Prover.

LeventErkok commented 1 month ago

I haven't quite reviewed these changes, but I'm wondering if the simple fix I added might suffice. I'm pretty old-school when it comes to coding, so unless I'm missing a particular advantage of this style, I'm not sure if the added complexity is worth it. What do you think?

LeventErkok commented 1 month ago

I think the changes here are quite complicated and I'm failing to see how it addresses the original issue without adding additional complexity. (The simple API addition seems to do the trick.) Feel free to comment on that ticket if you still have issues using the API.