search

Lever-age / frontend

Leverage user facing frontend
GNU Affero General Public License v3.0
1 stars 6 forks source link

Some files do not properly follow Angular naming conventions. #53

Open mchalet opened 7 years ago

mchalet commented 7 years ago

Description:

The angular style guide (https://angular.io/styleguide#!#naming) recommends using the following convention for file naming : feature-name.type.ts. The project files do not currently follow this convention. For example, aboutpage.component.ts should be about-page.component.ts.

Wireframe: One of "NEEDED" or "ATTACHED". If wireframe is available then it will be attached.

Software Functionality:

We should use a consistent file naming convention, in accordance with Angular recommendations, when introducing new files.

medy-io commented 7 years ago

A little late to the party but since this might be a throw away iteration we might want to stay away from granular tasks like this unless devs have issues understanding files. That way we don't have to work that hard :)

lottspot commented 7 years ago

I'm mostly in agreement with Chris here-- We all have limited time and it may not be best spent worrying about this during this particular iteration. However, we might want to keep this open as a "someday" todo item. I have no opinion on how closely we do or don't adhere to the angular naming convention, but I have a strong opinion about using a consistent naming convention; our conventions are currently mixed.

Some day we'll want to fix that, but I don't think today is the day to get bogged down on it.