search

LewisGaul / minegauler

A clone of the original minesweeper game with many added features
GNU General Public License v3.0
12 stars 8 forks source link

Ensure the project works on Python 3.8 #11

Closed LewisGaul closed 4 years ago

LewisGaul commented 4 years ago

It seems the version of PyQt5-sip in use (PyQt5-sip==4.19.13) is not available on Python 3.8, but the latest version is causing a crash in the tests (not just on 3.8)...

LewisGaul commented 4 years ago

On Windows the app runs on 3.8 after doing pip install pyqt5 attrs, which uses the latest version of PyQt5-sip (12.7.0??!). On WSL (Ubuntu), however, I'm seeing


$python -m minegauler
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, webgl, xcb.

Aborted (core dumped)
LewisGaul commented 4 years ago

Using QT_DEBUG_PLUGINS=1 shows there is a new dependency from PyQt5>=12.0 libqxcb.so -> libxkbcommon-x11.so.0, which can be solved with sudo apt install libxkbcommon-x11-0.

See https://www.riverbankcomputing.com/pipermail/pyqt/2019-February/041363.html.

LewisGaul commented 4 years ago

I'm not sure why there is this new dependency, and whether it should automatically be included when you pip install pyqt5 (it currently doesn't seem to be).

As far as I remember, I didn't have to install any other similar dependencies for PyQt5, so to avoid people having to do this, I'm not going to bump the version of PyQt5 in requirements.txt. This means that the requirements listed in requirements.txt are not available for Python3.8.

The application runs fine on Python3.8 with the latest version of PyQt5.