added Welcome message when GAMESTATE == READY

[kimmyd70]

within 73-89 of minegauler/minegauler/frontend/main_window.py

[LewisGaul]

I appreciate the effort, but this doesn't appear to have been tested at all. It is quite hard to hit the code you've added, but when you do it crashes the app with:

Traceback (most recent call last):
  File "C:\Users\legaul\Documents\personal\minegauler\minegauler\frontend\main_window.py", line 753, in _open_retrieve_highscores_modal
    "No highscores database found when searching along the path "
  File "C:\Users\legaul\Documents\personal\minegauler\minegauler\frontend\main_window.py", line 84, in _msg_popup
    if GameState == READY:
NameError: name 'READY' is not defined

Please get in contact if you'd like to help out.

[kimmyd70]

Lewis, I appreciate the feedback and I also owe you an apology. This was a partnered class assignment (to find a fix and attempt it), but I forgot to circle back and let you know our code was resoundingly unsuccessful and suggest you should scrap it.

Again, I’m so sorry you had to ping me!

Kim

Btw: I love your project and I wish we’d had more time to work this solution!

On Aug 17, 2021, at 3:21 PM, Lewis Gaul @.***> wrote:

 I appreciate the effort, but this doesn't appear to have been tested at all. It is quite hard to hit the code you've added, but when you do it crashes the app with:

Traceback (most recent call last): File "C:\Users\legaul\Documents\personal\minegauler\minegauler\frontend\main_window.py", line 753, in _open_retrieve_highscores_modal "No highscores database found when searching along the path " File "C:\Users\legaul\Documents\personal\minegauler\minegauler\frontend\main_window.py", line 84, in _msg_popup if GameState == READY: NameError: name 'READY' is not defined Please get in contact if you'd like to help out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.