search

LewisGaul / minegauler

A clone of the original minesweeper game with many added features
GNU General Public License v3.0
12 stars 8 forks source link

Fix errors from pylint/mypy #158

Open LewisGaul opened 2 years ago

deepgandhi commented 2 years ago

Need more details and discription about location of file and error.

LewisGaul commented 2 years ago

Hey @deepgandhi, I've just pushed a pylint config file (use the dev branch as the base).

You can find errors by running e.g.:

pip install pylint
pylint minegauler/shared/utils.py

This shows only the errors in the specified file, in this case:

$pylint minegauler/shared/utils.py
************* Module minegauler.shared.utils
minegauler/shared/utils.py:115:2: W0511: @@@LG Some attention please :) (fixme)
minegauler/shared/utils.py:88:12: W0612: Unused variable 'j' (unused-variable)
minegauler/shared/utils.py:181:12: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
minegauler/shared/utils.py:57:0: W0611: Unused import paths (unused-import)

Any of those errors are open for fixing.

In general the 'fixme' warnings might not be easy to sort, and there will be some false positives. If you're unsure about any feel free to ask here or in GitHub Discussions.

deepgandhi commented 2 years ago

Does pylint is to be checked with all files?

LewisGaul commented 2 years ago

Does pylint is to be checked with all files?

Yep pylint can be used to find suggestions for cleaner code in any of the files. I'd probably suggest focusing on minegauler/core/ first. I've left a review on your PR that would be good to address first.