LewisGaul / minegauler

A clone of the original minesweeper game with many added features
GNU General Public License v3.0
11 stars 8 forks source link

pylint file encoding and mode correction #187

Closed deepgandhi closed 2 years ago

deepgandhi commented 2 years ago

I have run pylint on all the files under minegauler and made consistent corrections for mode and encoding for reading and writing the files.

codecov[bot] commented 2 years ago

Codecov Report

Merging #187 (f323efe) into dev (ed7895e) will not change coverage. The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #187   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          44       44           
  Lines        3805     3805           
=======================================
  Hits         2668     2668           
  Misses       1137     1137           
Impacted Files Coverage Δ
minegauler/frontend/main_window.py 50.65% <0.00%> (ø)
minegauler/core/controller.py 98.37% <100.00%> (ø)
minegauler/core/engine.py 83.48% <100.00%> (ø)
minegauler/shared/utils.py 80.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed7895e...f323efe. Read the comment docs.

LewisGaul commented 2 years ago

Could you run the black autoformatter over your changes please, which you can do with "python -m black .". This actually picks up some formatting in your similar changes that have already been merged.

I need to put together a contributing guide (#100) and a CI check to make this clearer :)

deepgandhi commented 2 years ago

Could you run the black autoformatter over your changes please, which you can do with "python -m black .". This actually picks up some formatting in your similar changes that have already been merged.

I have ran the black and the output i received is as under:

$ python -m black minegauler/frontend/main_window.py
All done! \u2728 \U0001f370 \u2728
1 file left unchanged.

$ python -m black minegauler/core/engine.py
All done! \u2728 \U0001f370 \u2728
1 file left unchanged.

$ python -m black minegauler/shared/utils.py
All done! \u2728 \U0001f370 \u2728
1 file left unchanged.
LewisGaul commented 2 years ago

That's strange, because when I run black on your branch it fixes your formatting...

21:07:30 LEGAUL-P12W1:minegauler/(dev)$python -m black .
reformatted minegauler/core/engine.py
reformatted minegauler/core/controller.py
reformatted minegauler/frontend/main_window.py
reformatted tests/mut/core/regular/controller_test.py

4 files reformatted, 84 files left unchanged.

I've pushed those changes to your branch.